This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
re: Patch to c-common.c (printf-format checking)
- To: "Jörn Padeken" <Joern dot Padeken at dsa-ac dot de>
- Subject: re: Patch to c-common.c (printf-format checking)
- From: Gavin Romig-Koch <gavin at cygnus dot com>
- Date: Tue, 21 Mar 2000 16:24:37 -0500 (EST)
- Cc: gcc-patches at gcc dot gnu dot org
- References: <200003211510.QAA27302@KOMSERVER.dsa-ac.de>
Thank you for the patch, but I don't think this would be a
improvement to the compiler.
The *-precision specifier expects a signed int as its argument.
There are lots of cases where an unsigned int will work, but
there are (at least a few) cases where it won't. The -Wformat
warnings should catch as many mistakes as it reasonably can.
I think the *-width code is wrong to allow unsigned ints.
-gavin...