This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch to create builtin bzero
- To: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>
- Subject: Re: Patch to create builtin bzero
- From: Richard Henderson <rth at cygnus dot com>
- Date: Thu, 23 Mar 2000 16:36:36 -0800
- Cc: egcs-patches at egcs dot cygnus dot com
- References: <200003232342.SAA13782@caip.rutgers.edu>
On Thu, Mar 23, 2000 at 06:42:26PM -0500, Kaveh R. Ghazi wrote:
> I didn't see any C++ problems... but here's a revised patch anyway
> which builds a new chain of memset parameters.
You didn't play with the right combinations of inline functions.
I just ran into this when the sibcall code mucked with the trees
it received. ;-)
> Okay to install?
Not quite.
> + TREE_OPERAND (exp, 1) = newarglist;
> +
> + result = expand_builtin_memset(exp);
> +
> + /* If the above call fails, delete the zero parameter. */
> + if (result == 0)
> + TREE_OPERAND (exp, 1) = arglist;
exp must always look *exactly* like it did before you got it.
Always put arglist back.
r~