This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Sparc tail calls (take 4)
- To: Jeffrey A Law <law at cygnus dot com>
- Subject: Re: [PATCH] Sparc tail calls (take 4)
- From: Richard Henderson <rth at cygnus dot com>
- Date: Fri, 24 Mar 2000 12:22:46 -0800
- Cc: Jakub Jelinek <jakub at redhat dot com>, gcc-patches at gcc dot gnu dot org
- References: <20000324112526.B19711@cygnus.com> <20933.953926036@upchuck>
On Fri, Mar 24, 2000 at 12:27:16PM -0700, Jeffrey A Law wrote:
> A similar check used to be in the code. Presumably it got lost when
> you had to revamp the block note handling:
Hmm. No, it's still there.
if (pass == 0)
{
tail_call_insns = insns;
/* If the current function's argument block is not large enough
to hold the outoing arguments, or we encountered some other
situation we couldn't handle, zero out the sequence. */
if (current_function_args_size < args_size.constant
|| sibcall_failure)
tail_call_insns = NULL_RTX;
So, Jakub, what exactly prompted you to add the other bit,
a failure, or just inspection? I'd probably agree that the
check should be moved up there next to the other argument
checks, just for clarity.
r~