This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: simple calls.c cleanups
- To: Jan Hubicka <hubicka at atrey dot karlin dot mff dot cuni dot cz>
- Subject: Re: simple calls.c cleanups
- From: Richard Henderson <rth at cygnus dot com>
- Date: Thu, 30 Mar 2000 10:16:41 -0800
- Cc: egcs-patches at egcs dot cygnus dot com
- References: <20000330134830.A15266@atrey.karlin.mff.cuni.cz>
On Thu, Mar 30, 2000 at 01:48:30PM +0200, Jan Hubicka wrote:
> While implementing it I found that we don't support nothrow and malloc
> attributes at the fuction types. Is that some kind of design decision
> or just omision?
I thought we did support nothrow on types. Oh, though it's
in the C++ part of the tree. Oh well, the CALL_EXPR also has
nothrow marked.
Dunno about the malloc attribute.
> if (tname[0] == 's')
> {
> ! if ((tname[1] == 'e'
> ! && (! strcmp (tname, "setjmp")
> ! || ! strcmp (tname, "setjmp_syscall")))
> ! || (tname[1] == 'i'
> ! && ! strcmp (tname, "sigsetjmp"))
> ! || (tname[1] == 'a'
> ! && ! strcmp (tname, "savectx")))
> ! flags |= ECF_RETURNS_TWICE;
I bet this whole function would get much cleaner if we
used gprof to recognize the functions. Not a requirement
for this patch, but a suggestion for future cleanup.
> ! if (flags & (ECF_CONST || ECF_MALLOC))
"|"
Otherwise ok.
r~