This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PREFERRED_STACK_BOUNDARY/function calling code fix
- To: hubicka at atrey dot karlin dot mff dot cuni dot cz
- Subject: Re: PREFERRED_STACK_BOUNDARY/function calling code fix
- From: Mark Mitchell <mark at codesourcery dot com>
- Date: Wed, 01 Mar 2000 09:00:37 -0800
- Cc: grahams at rcp dot co dot uk, egcs-patches at egcs dot cygnus dot com, rth at cygnus dot com
- Organization: CodeSourcery, LLC
- References: <20000223165651.E32692@atrey.karlin.mff.cuni.cz><38BAF586.FE2CABC8@rcp.co.uk><20000301124607.B24452@atrey.karlin.mff.cuni.cz>
>>>>> "Jan" == Jan Hubicka <hubicka@atrey.karlin.mff.cuni.cz> writes:
Jan> Graham, it would be also nice idea to add your testcase to
Jan> the testsuite. I've bootstraped with older version of this
Jan> patch, so before installing it I only run the testsuite, so
Jan> it looks like we don't have any testcase for the nested
Jan> functions calls, that was all broken after my patch.
I think it's fine to add things to the testsuite, even sometimes when
they're slightly redundant with the bootstrap.
But, we should always bootstrap. I, myself, am sometimes sorely
tempted to make just one little tweak before checkin. Although I
sometimes fail to do so, I try to will myself to resist that
temptation, unless its a change entirely contained within a comment.
--
Mark Mitchell mark@codesourcery.com
CodeSourcery, LLC http://www.codesourcery.com